Skip to content

fix(dashboards): Updates dashboard quota to not count prebuilt dashboards #103985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 26, 2025
Merged

fix(dashboards): Updates dashboard quota to not count prebuilt dashboards #103985

merged 2 commits into from
Nov 26, 2025
+33 −1

Conversation

@edwardgou-sentry
Copy link
Contributor

@edwardgou-sentry edwardgou-sentry commented Nov 25, 2025

Filters out prebuilt dashboards when fetching count to check against dashboard quota

@edwardgou-sentry edwardgou-sentry requested a review from a team November 25, 2025 17:46
@edwardgou-sentry edwardgou-sentry requested a review from a team as a code owner November 25, 2025 17:46
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 25, 2025
@codecov
Copy link

codecov bot commented Nov 25, 2025 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
30028 1 30027 240
View the top 1 failed test(s) by shortest run time 
tests.sentry.core.endpoints.test_organization_index.OrganizationsCreateTest::test_valid_slugs
Stack Traces | 1.72s run time 
#x1B[1m#x1B[.../core/endpoints/test_organization_index.py#x1B[0m:190: in test_valid_slugs
    response = self.get_success_response(name=input_slug, slug=input_slug)
#x1B[1m#x1B[.../sentry/testutils/cases.py#x1B[0m:628: in get_success_response
    assert_status_code(response, 200, 300)
#x1B[1m#x1B[.../sentry/testutils/asserts.py#x1B[0m:47: in assert_status_code
    assert minimum <= response.status_code < maximum, (
#x1B[1m#x1B[31mE   AssertionError: (500, b'{"detail":"Internal Error","errorId":null}')#x1B[0m
#x1B[1m#x1B[31mE   assert 500 < 300#x1B[0m
#x1B[1m#x1B[31mE    +  where 500 = <Response status_code=500, "application/json">.status_code#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Abdkhan14
Abdkhan14 approved these changes Nov 26, 2025
View reviewed changes
Copy link
Contributor

@Abdkhan14 Abdkhan14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 🚢

@edwardgou-sentry edwardgou-sentry merged commit 13d530a into master Nov 26, 2025
67 checks passed
@edwardgou-sentry edwardgou-sentry deleted the egou/fix/dont-count-prebuilt-dashboards-against-quota branch November 26, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Abdkhan14 Abdkhan14 Abdkhan14 approved these changes

Assignees

No one assigned

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@edwardgou-sentry @Abdkhan14